fix: correct return type of useChain hook #32
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With current tsconfig (
"strictNullChecks": false), TS infers return type ofArray.find()as non-nullable, even though it can returnundefinedat runtime.This leads type mismatch here:
This returns
undefinedas well.There are more potential type mismatches of this sort.
Turning on strictNullChecks would be a more desirable solution in the long term.